Use a macro for defining benchmarks #1464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kobzol
force-pushed
the
runtime-define-benchmark
branch
from
c3d02bd to
04344a2
Compare
nnethercote
reviewed
Oct 13, 2022
nnethercote
approved these changes
Oct 13, 2022
Kobzol
force-pushed
the
runtime-define-benchmark
branch
from
04344a2 to
2df61ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done mostly for forward compatibility. In the future, it might make sense to normalize the benchmark functions (e.g. apply
#[inline(never)]to them, align them to some boundary to reduce code alignment issues etc.). This can be a bit difficult to do with closures, maybe we will need to generate actual functions.For that reason, I suggest to change benchmark definition to a macro. That will allow us to easily change the inner representation in the future without needing to change the code of all runtime benchmarks. This PR introduces the macro, but still keeps benchmarks as closures.