Hide old rust-timer comments when a summary is posted
#1490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylev
requested changes
Nov 4, 2022
Kobzol
force-pushed
the
github-hide-comments
branch
from
03fa10d to
f8545c9
Compare
|
Added a comment about |
rylev
approved these changes
Nov 4, 2022
|
I think that old summaries can actually be quite useful, but we can open a discussion about that later I guess. |
Kobzol
force-pushed
the
github-hide-comments
branch
from
f8545c9 to
8966336
Compare
|
I suppose that there's not a practical way of testing this without merging this? 😅 @Mark-Simulacrum |
|
I would just merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a perf. summary is posted to a PR, all other non-summary comments made by the bot on the PR will be minimized. I copied the code from rust-lang/rust-log-analyzer#56 to implement this.
I have no idea how to test this though 🤷♂️
Fixes: #1488