Skip to content

Add support for profiling the compiler with Samply. #1522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

nnethercote
Copy link
Contributor

I just tried out Samply, it works on rustc and seems like a nice addition.

r? @Kobzol

Copy link
Contributor

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it locally. Very nice visualisation of the stacks! A nice addition to the profiler suite.

Could you just add quick a smoke test for it in ci/check-profiling.sh? It should be also installed on CI, in the part where we install cargo-llvm-lines.

@nnethercote
Copy link
Contributor Author

The test fails with:

Failed to start profiling: Operation not permitted (os error 1)

I think Samply can't be tested on CI for the same reason as perf :(

@nnethercote
Copy link
Contributor Author

I updated, removing the test, but adding a comment to ci/check-profiling.sh explaining why Samply isn't tested.

@nnethercote nnethercote merged commit 10cdee3 into rust-lang:master Feb 6, 2023
@nnethercote nnethercote deleted the add-samply branch February 6, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants