Log preparation errors #1553
Merged
Log preparation errors #1553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`crossbeam-utils`
Kobzol
force-pushed
the
remove-crossbeam
branch
from
41f773c to
4735406
Compare
|
CC @Mark-Simulacrum, now it doesn't ignore errors and also shouldn't panic on them :) Tested locally that both a compilation error and a panic within a preparation thread now logs the error into the database properly. |
Mark-Simulacrum
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds logging for errors during preparation. If preparation of a benchmark fails in any way or panics (shouldn't happen, hopefully), the error will now be correctly propagated and logged.
This PR also removes dependency on
crossbeam-utils.