Log preparation times #1559
Merged
Log preparation times #1559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Getting these into the database would take more hassle and this is enough for our logs to show the data. This will help us decide whether to invest in moving preparation to be done in parallel across many benchmarks or perhaps even in advance on a separate machine. Both of those are quite a bit of refactoring, so we should figure out if they're worth it first.
Kobzol
approved these changes
Mar 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting these into the database would take more hassle and this is enough for our logs to show the data. This will help us decide whether to invest in moving preparation to be done in parallel across many benchmarks or perhaps even in advance on a separate machine. Both of those are quite a bit of refactoring, so we should figure out if they're worth it first.