For Cachegrind, aggregate all jemalloc functions into a single entry. #1561
+46
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark-Simulacrum
approved these changes
Mar 23, 2023
Kobzol
reviewed
Mar 23, 2023
Because a single entry like this: ``` 120,365,108 (8.7%) <all-jemalloc-files>:<all-jemalloc-functions> ``` is much more helpful than dozens of entries like this: ``` 1,900,760 (0.9%) /home/njn/dev/rust2/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/build/jemalloc-sys-1e20251078fe5355/out/build/include/jemalloc/internal/rtree.h:free 9,296,168 (0.7%) /home/njn/dev/rust2/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/build/jemalloc-sys-1e20251078fe5355/out/build/include/jemalloc/internal/jemalloc_internal_inlines_c.h:malloc 7,926,636 (0.6%) /home/njn/dev/rust2/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/build/jemalloc-sys-1e20251078fe5355/out/build/src/jemalloc.c:free 7,905,743 (0.6%) /home/njn/dev/rust2/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/build/jemalloc-sys-1e20251078fe5355/out/build/include/jemalloc/internal/cache_bin.h:free 7,834,577 (0.6%) /home/njn/dev/rust2/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/build/jemalloc-sys-1e20251078fe5355/out/build/include/jemalloc/internal/cache_bin.h:malloc 5,425,997 (0.4%) /home/njn/dev/rust2/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/build/jemalloc-sys-1e20251078fe5355/out/build/src/arena.c:_rjem_je_arena_ralloc 4,268,616 (0.3%) /home/njn/dev/rust2/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/build/jemalloc-sys-1e20251078fe5355/out/build/src/jemalloc.c:do_rallocx 3,539,679 (0.3%) /home/njn/dev/rust2/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/build/jemalloc-sys-1e20251078fe5355/out/build/src/arena.c:_rjem_je_arena_ralloc_no_move 3,093,308 (0.2%) /home/njn/dev/rust2/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/build/jemalloc-sys-1e20251078fe5355/out/build/include/jemalloc/internal/sz.h:malloc 2,393,337 (0.2%) /home/njn/dev/rust2/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/build/jemalloc-sys-1e20251078fe5355/out/build/src/arena.c:_rjem_je_arena_cache_bin_fill_small 2,371,694 (0.2%) /home/njn/dev/rust2/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/build/jemalloc-sys-1e20251078fe5355/out/build/include/jemalloc/internal/rtree.h:tcache_bin_flush_edatas_lookup.constprop.0 2,309,382 (0.2%) /home/njn/dev/rust2/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/build/jemalloc-sys-1e20251078fe5355/out/build/src/jemalloc.c:malloc ... ``` (And in reality, those jemalloc function entries are interleaved with many non-jemalloc entries, making them even harder to read.)
nnethercote
force-pushed
the
aggregate-jemalloc
branch
from
1fcc070 to
e1ef705
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because a single entry like this:
is much more helpful than dozens of entries like this:
(And in reality, those jemalloc function entries are interleaved with many non-jemalloc entries, making them even harder to read.)