Skip to content

Refactor site to make it easier to introduce runtime benchmarks #1608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 5, 2023

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Jun 3, 2023

Various simplifications, removing of unused code and fixing clippy issues. Best reviewed commit by commit.

@Kobzol Kobzol requested a review from nnethercote June 3, 2023 20:08
@Kobzol Kobzol force-pushed the runtime-compare-refactoring branch from a4147af to 055c5a7 Compare June 4, 2023 07:42
Copy link
Contributor

@nnethercote nnethercote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clippy is getting quite clever. So many unnecessary &s!

Should we add Clippy to the CI test workflow, to ensure the code is always Clippy-compliant?

@Kobzol Kobzol force-pushed the runtime-compare-refactoring branch from 055c5a7 to 58920cb Compare June 5, 2023 16:48
@Kobzol Kobzol enabled auto-merge June 5, 2023 16:49
@Kobzol Kobzol merged commit 3563130 into rust-lang:master Jun 5, 2023
@Kobzol Kobzol deleted the runtime-compare-refactoring branch June 5, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants