Change how errors are stored in the DB #1641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like CI is failing? |
|
Thanks, fixed. |
Removes the `error_series` table, which was probably useless anyway, and adds a `benchmark` column to the `error` table instead. This will allow us to also store runtime errors in to the crate, e.g. under the name `runtime:foo`.
Mark-Simulacrum
approved these changes
Jul 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the
error_seriestable, which was probably useless anyway, and adds abenchmarkcolumn to theerrortable instead. This will allow us to also store runtime errors in to the crate, e.g. under the nameruntime:foo.Tested this locally with both SQLite and Postgre. Old errors were migrated correctly and new errors were also recorded fine. Not sure for how long will the migration run, but hopefully there aren't that many errors in the database.
I had to create a new table in the migration, because it was not possible to drop the previous primary key.