Make skipping of already benchmarked runtime benchmarks more precise #1668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, running a runtime benchmark suite would store all found runtime steps into the DB. That meant that if you tried to run a different set of benchmarks with the same artifact ID, they would not be executed at all. Now only the benchmark groups containing the actually selected benchmarks will be stored as steps into the DB, and thus skipped on follow-up executions.
It wasn't really useful for anything, and the count wasn't precise after the previous commit.
nnethercote
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, running a runtime benchmark suite would store all found runtime groups into the DB. That meant that if you tried to run benchmark X located in group A, and then later benchmark Y located in group 2 (both with the same artifact ID), then Y would not be executed at all, instead it would be skipped, since group 2 would already be stored in the DB as completed.
Now only the benchmark groups containing the actually selected benchmarks will be stored as steps into the DB, which resolves this issue.