Skip to content

Add a warning to compare page that runtime benchmarks are experimental #1685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Add a warning to compare page that runtime benchmarks are experimental #1685

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions site/frontend/src/pages/compare/runtime/runtime-page.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,21 @@ const filteredSummary = computed(() => computeSummary(comparisons.value));
@change="updateFilter"
/>
<OverallSummary :summary="filteredSummary" />
<div class="warning">
Runtime benchmarks are currently experimental and the results might be quite
unstable/noisy. Please take this into account!
</div>
<ComparisonsTable
:comparisons="comparisons"
:has-non-relevant="allComparisons.length > 0"
:show-raw-data="filter.showRawData"
/>
</template>

<style scoped lang="scss">
.warning {
margin: 5px 0;
text-align: center;
font-weight: bold;
}
</style>