Skip to content

Add --group flag to runtime benchmark/profiling command #1692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Aug 7, 2023

This flag allows us to choose a specific benchmark group that will be compiled, when running runtime benchmarks or profiling. This serves purely as a latency reduction optimization for local experiments, because now even with --no-isolate it takes some time until a runtime benchmark starts executing, because all compiled groups are currently executed first with the list parameter. And since some of the groups perform non-trivial work in main (e.g. compression currently), this can take a few seconds, which is annoying.

@Kobzol Kobzol requested a review from nnethercote August 7, 2023 14:36
@Kobzol Kobzol merged commit 481d7ba into rust-lang:master Aug 8, 2023
@Kobzol Kobzol deleted the runtime-group-filter branch August 8, 2023 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants