Simplify handling of self-profile data in collector
#1781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't really know this code -- but looking through the diff the changes make sense to me. |
michaelwoerister
approved these changes
Jan 4, 2024
Mark-Simulacrum
approved these changes
Jan 8, 2024
…eme` crate Also removes support for parsing the old 3 file self-profile results.
Kobzol
force-pushed
the
measureme-modifications
branch
from
5b0e9b9 to
7dd7436
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR performs several changes to the way we handle self-profile files in the
collector, in order to simplify it:rustc-faketocollector.summarizebinary, theanalyzemecrate is used directly to parse the self-profile results.analyzemesince 2020, so even if we were able to upload this format to S3 from thecollector(for some veeeery oldrustcversions), it could not be read by the site, which uses thestableversion ofanalyzeme(currently0.11).measuremebinaries are no longer installed on thecollector, since the binaries are no longer used during benchmarking.