Skip to content

Remove trace log that logs touching a file #1799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2024

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Jan 12, 2024

I don't think that it provides a lot of value, but it sure does provide a lot of garbage output - easily hundreds of thousands of lines per benchmark, which makes it harder to search through the logs.

Copy link
Member

@Mark-Simulacrum Mark-Simulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's been useful in the past when debugging rebuild failures (i.e. building too much), but I think that may also have been before we started touching as much as we do now. Seems good.

@Kobzol Kobzol merged commit 67d16be into rust-lang:master Jan 13, 2024
@Kobzol Kobzol deleted the remove-touch-trace branch January 13, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants