Skip to content

Support missing tables migration #1836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

s7tya
Copy link
Contributor

@s7tya s7tya commented Mar 6, 2024

In this PR, I added support for migrating runtime_pstat, runtime_pstat_series, artifact_size that were missing in current migrators.

@s7tya s7tya changed the title Support runtime related tables migration Support missing tables migration Mar 7, 2024
Copy link
Contributor

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

TBH, I think that we could just delete the SQLite to Postgres migration program, I don't see any value in it, and it requires maintenance from time to time.

@Kobzol Kobzol merged commit 149897b into rust-lang:master Mar 7, 2024
@s7tya
Copy link
Contributor Author

s7tya commented Mar 7, 2024

I'm agree with that. However, if we don't remove it, maybe we could add sqlite-to-postgres-to-sqlite. (just an idea though)

@s7tya s7tya deleted the support-runtime-related-tables-migration branch May 25, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants