Load 'perf/info' and 'perf/get' in Comparison page asynchronously #1860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, 'perf/info' would load then a request would be made to 'perf/get' in `loadCompareData`. By moving `await` after `loadCompareData`, `perf/get` is requested then `perf/info`. I don't know if `await` is necessary but doesn't seem to hurt.
Kobzol
approved these changes
Mar 15, 2024
Zentrik
added a commit
to Zentrik/rustc-perf
that referenced
this pull request
Mar 28, 2024
Zentrik
added a commit
to Zentrik/rustc-perf
that referenced
this pull request
Apr 27, 2024
Zentrik
added a commit
to Zentrik/rustc-perf
that referenced
this pull request
Jun 23, 2024
Zentrik
added a commit
to Zentrik/rustc-perf
that referenced
this pull request
Jun 23, 2024
Zentrik
added a commit
to Zentrik/rustc-perf
that referenced
this pull request
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, 'perf/info' would load then a request would be made to 'perf/get' in
loadCompareData. By movingawaitafterloadCompareData,perf/getis requested thenperf/infowithout a wait in between. I don't know ifawaitis necessary but doesn't seem to hurt.I don't know much js, but hopefully this is fine as it seems to work locally. It saves about 50-100ms for me.