Skip to content

Update deeply-nested-multi to increase type length limit #1936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Jul 3, 2024

Needed because of changes done in rust-lang/rust#125507. See this conversation.

@lqd lqd merged commit ac602ef into rust-lang:master Jul 3, 2024
11 checks passed
@Kobzol Kobzol deleted the benchmark-update-deeply-nested-multi branch July 3, 2024 19:42
@lqd
Copy link
Member

lqd commented Jul 4, 2024

I think between this change and the PR causing the regressions, the graph has now become super hard to read, having to show such a wide range. For example https://perf.rust-lang.org/index.html?start=2024-05-03&end=83217ae97e94eb43ce31396b49a938608f7f9c06&benchmark=deeply-nested-multi&profile=opt&scenario=incr-unchanged&stat=instructions%3Au&kind=raw

@Kobzol
Copy link
Contributor Author

Kobzol commented Jul 4, 2024

It only affects this one benchmark, and it will resolve itself in ~30 days. Do you think that some changes to graph handling are warranted or we can just wait?

@lqd
Copy link
Member

lqd commented Jul 4, 2024

Hopefully that situation is uncommon. Otherwise some help in navigating or selecting data with the mouse could be useful.

The first could be eg also having buttons to control the range, so that you could go back 1 commit at a time and here after 2 we'd be back to the regular range.

The second could be allowing easier mouse selection at the edges. Right now it doesn't seems super easy to select, you have to go out of your way and know there's something to select, as the points must be on the 0 edge or something.

In general, it may be easier if the graph were bigger: the full history graph is still small and most of the page is empty.

It will not fix itself for the history graph, but we don't expect people to be looking at this one too much, I hope.

@Kobzol
Copy link
Contributor Author

Kobzol commented Jul 4, 2024

Good ideas. Created #1938 to track this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants