Do not return empty commit list when a parent commit is missing #1957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Asked more people for a review, whoever gets to this first to unblock the queue :) |
This can happen during force pushes to rust-lang/rust. If a parent commit is missing, just run the benchmark, the result won't have any parent available.
Kobzol
force-pushed
the
fix-site-queue-error
branch
from
39bd781 to
73e7a7a
Compare
lqd
approved these changes
Aug 1, 2024
|
If there isn't a parent, the benchmark should run, but the compare page for that run will probably error out (hopefully nothing more sinister will happen). |
|
Ah right this is in the reordering to make sure the parent commit is benchmarked before the commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can happen during force pushes to rust-lang/rust. If a parent commit is missing, just run the benchmark, the result won't have any parent available.