-
Notifications
You must be signed in to change notification settings - Fork 156
Update dependencies #1961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Update dependencies #1961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63074e7
to
501e549
Compare
Merged
It is already being used on CI as the minimum version, and allows us to remove some packages.
501e549
to
92c0ba3
Compare
lqd
approved these changes
Oct 3, 2024
Ok, let's see what happens. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are five packages in the workspace of this repository, and they have a lot of dependencies. Now that
rustc-perf
can be used as a part of bootstrap, it would be nice if it was a bit leaner and faster to compile.This PR removes several unneeded dependencies and updates some other dependencies to reduce the total number of crates compiled. For the
collector
binary, this PR gets its dependency count down from 300 to 294 (I think that more improvements are possible by doing more major dependency updates, but this PR already does a lot, so let's keep that for another PR).