Make loading of PEM certificates async #1971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark-Simulacrum
approved these changes
Sep 2, 2024
Running the blocking client inside async context was causing issues with Tokio, and it was a hack anyway. This also allows us to remove a feature from `reqwest` and remove the `lazy_static` dependency.
Kobzol
force-pushed
the
certificates-async
branch
from
5c49a3e to
b215a17
Compare
Before it was unified from the `database` package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the blocking client inside async context was causing issues with Tokio (when the blocking client was dropped, it was sometimes causing panics in tokio), and it was a hack anyway. This also allows us to remove a feature from
reqwestand also remove thelazy_staticdependency.