Skip to content

Remove artifact from PR queue when purging it #2000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Oct 23, 2024

This should make the purge_artifact command more universal, and really purge the given artifact from all places in DB.

@lqd
Copy link
Member

lqd commented Oct 23, 2024

Are we denying errors only on windows CI?

Copy link
Member

@lqd lqd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know where to check the schema but assuming there's no FK or whatever, this look good to me

@Kobzol
Copy link
Contributor Author

Kobzol commented Oct 23, 2024

Are we denying errors only on windows CI?

No, but we run beta on windows CI, that's the difference :)

Copy link
Member

@lqd lqd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my previous comment was supposed to be an approval...

This should make the `purge_artifact` command more universal, and really purge the given artifact from all places in DB.
@Kobzol Kobzol force-pushed the purge-artifact-pr branch from 446bb68 to 60fc307 Compare October 23, 2024 23:18
@Kobzol Kobzol enabled auto-merge October 23, 2024 23:19
@Kobzol Kobzol merged commit 6372f01 into rust-lang:master Oct 23, 2024
11 checks passed
@Kobzol Kobzol deleted the purge-artifact-pr branch October 23, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants