Skip to content

Update script-servo #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 30, 2020
Merged

Conversation

Mark-Simulacrum
Copy link
Member

Fixes #664

@nnethercote
Copy link
Contributor

This should be called script-servo-2, like hyper-2.

@Mark-Simulacrum
Copy link
Member Author

I was debating that, actually - it's now pretty trivial for us to rename old runs, so we could just rename the old one. But that's probably more hassle than it's worth, so I'll go ahead and update this as you suggest.

@Mark-Simulacrum Mark-Simulacrum force-pushed the script-servo branch 6 times, most recently from 6cea387 to 868488c Compare June 29, 2020 13:30
@Mark-Simulacrum Mark-Simulacrum force-pushed the script-servo branch 3 times, most recently from eed4dfc to 145f725 Compare June 29, 2020 15:00
@Mark-Simulacrum
Copy link
Member Author

It looks like this is likely a regression in build times -- previously I believe we didn't run bindgen on every (commit) of script-servo but now we will. It doesn't look like this is readily changeable either... I'm going to merge this in and deploy to the collector, though, and we'll see how our queue looks like after a few days. If needed we can explore "vendoring" or something.

@Mark-Simulacrum Mark-Simulacrum merged commit 1f5830f into rust-lang:master Jun 30, 2020
@Mark-Simulacrum Mark-Simulacrum deleted the script-servo branch June 30, 2020 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update script-servo benchmark
2 participants