Reduce run durations #692
Merged
Reduce run durations #692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't adjust all the benchmarks yet; for most of them touching all the files is fine since they're a single crate anyway.
Mostly intended for debugging.
Previously we'd rebuild selectors after copying as the build script depended on the absolute path of the crate rather than a workspace-relative path. This is a Cargo bug, which is being fixed, but we'd like to have the wins sooner rather than later.
Mark-Simulacrum
force-pushed
the
cut-duration
branch
from
60c5f34 to
61bad5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
style-servoandscript-servo-2to not spuriously rebuild a bunch of dependencies on every iteration.RUST_LOG=collector_raw_cargo=trace, mostly intended for debugging.In sum, this PR brings the script-servo builder from 1h 4m 39s to 48m 47s and the general builder from 45m 2s to 34m 19s. I expect even larger effects on the collection machine, since our CI only does Check/Doc builds which are quite fast to recover from spurious rebuilding (unlike Opt/Debug runs, which are quite a bit more expensive).