Skip to content

Automatically mark PRs with benchmark results as rollup=never #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Automatically mark PRs with benchmark results as rollup=never #700

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion site/src/github.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,19 @@ pub async fn post_finished(data: &InputData) {
&data.config,
commit.pr,
format!(
"Finished benchmarking try commit ({}): [comparison url]({}).",
"Finished benchmarking try commit ({}): [comparison url]({}).

Benchmarking this pull request likely means that it is \
perf-sensitive, so we're automatically marking it as not fit \
for rolling up. Please note that if the perf results are \
neutral, you should likely undo the rollup=never given below \
by specifying `rollup-` to bors.

Importantly, though, if the results of this run are \
non-neutral **do not** roll this PR up -- it will mask other \
regressions or improvements in the roll up.

@bors rollup=never",
commit.sha, comparison_url
),
)
Expand Down