Assert that we invoke rustc once per statistics run #717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark-Simulacrum
force-pushed
the
assert-single-build
branch
6 times, most recently
from
6704c6d to
d1882c2
Compare
For example CI doesn't really care about timings but does want raw cargo output.
Pair Doc and Check together -- both are fairly fast.
Mark-Simulacrum
force-pushed
the
assert-single-build
branch
from
d1882c2 to
bbd2096
Compare
Mark-Simulacrum
force-pushed
the
assert-single-build
branch
from
bbd2096 to
6a205a4
Compare
Mark-Simulacrum
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make certain that we aren't spuriously rebuilding anything when touching files to force a rebuild. This ensures that we don't regress the run time of our collections because of spurious rebuilds when adding new benchmarks. (The existing benchmarks are updated in this PR).
This also changes the collection to run all builds kinds on CI, not just Check and Doc. This is done in parallel.
As a follow-up, this also move the enablement of incremental compilation out of Cargo's hands. Cargo, unfortunately, considers
CARGO_INCREMENTAL=1to be a workspace property -- for our purposes, though, we really only care about the leaf crate. Because Cargo considers incremental compilation to also change fingerprints, this meant that we were building any in-workspace dependencies twice per build-kind, once with incremental on and once without it. That adds up rapidly -- especially for the already really long crates like script-servo, which have numerous workspace (path) dependencies.