Avoid collecting extraneous stuff on eprintln runs.
#726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnethercote
force-pushed
the
wrap-eprintln
branch
from
e5fb4a2 to
249a7e2
Compare
Currently, `collector eprintln` collects stderr output for the `cargo rustc` command. This means it will collect rustc's stderr output for the leaf crate, but *also* rustc's stderr output for build scripts that run for the leaf crate, and *also* for Cargo's stderr output for all of the above. This means it is different to all the other profilers, which only profile rustc on the leaf crate. With this change, `collector eprintln` now only collects rustc's stderr output for the leaf crate, so it matches the other profiler's behaviour. The commit also changes `time-passes` to use the same collection strategy as `eprintln`. This wasn't actually necessary, but I did it for consistency. Finally, the commit does some minor clean-ups.
nnethercote
force-pushed
the
wrap-eprintln
branch
from
249a7e2 to
b374d77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
collector eprintlncollects stderr output for thecargo rustccommand. This means it will collect rustc's stderr output for theleaf crate, but also rustc's stderr output for build scripts that run
for the leaf crate, and also for Cargo's stderr output for all of the
above.
This means it is different to all the other profilers, which only
profile rustc on the leaf crate.
With this change,
collector eprintlnnow only collects rustc's stderroutput for the leaf crate, so it matches the other profiler's behaviour.
The commit also changes
time-passesto use the same collectionstrategy as
eprintln. This wasn't actually necessary, but I did it forconsistency.
Finally, the commit does some minor clean-ups.