Skip to content

Update colors for slightly positive and negative #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2021

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Jan 23, 2021

The colors were a bit too faint I think.

Before:

Screenshot_2021-01-23 rustc performance data

After:

Screenshot_2021-01-23 rustc performance data(3)

@Mark-Simulacrum
Copy link
Member

Hm, those look a bit too bright and stand out more than the dark green...

@bjorn3
Copy link
Member Author

bjorn3 commented Jan 23, 2021

Maybe

image

.slightly-positive {
    color: #ff5050 !important;
}
.slightly-negative {
    color: #30ff30 !important;
}

@Mark-Simulacrum
Copy link
Member

That still looks like it'll stand out more. Maybe we should just leave them black? I would rather add a toggle to hide results <0.1/0.2 magnitude or so.

@bjorn3
Copy link
Member Author

bjorn3 commented Jan 23, 2021

Without colors it is much harder to find the positive and negative changes in a quick glance.

@tgnottingham
Copy link
Contributor

How about something like this?

rustc_perf_colors

.slightly-positive {
    color: #ea7272;
}
.slightly-negative {
    color: #74b374;
}

@Mark-Simulacrum
Copy link
Member

That looks much more reasonable to me.

@bjorn3
Copy link
Member Author

bjorn3 commented Jan 23, 2021

Yeah, that looks much better.

@Mark-Simulacrum Mark-Simulacrum merged commit 98fb609 into rust-lang:master Jan 23, 2021
@bjorn3 bjorn3 deleted the patch-1 branch January 24, 2021 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants