Add S-waiting-on-perf as soon as run is requested
#835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I realized after rust-lang#810 that it makes more sense to add the label as soon as the run is requested, since it's still "waiting on perf" even though the perf run itself hasn't started yet.
|
(CI failure looks spurious.) |
|
Hm CI is really struggling with apt archives I guess. I agree it's likely spurious though, so merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized after #810 that it makes more sense to add the label as soon
as the run is requested, since it's still "waiting on perf" even though
the perf run itself hasn't started yet.