Add triage 2021-05-25 #874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note to self - needs check-in on action items from last week and TWIR. |
|
does/should the script also look at max-rss regressions btw ? |
|
It does not; I try to check via the graph most weeks. max-rss is sufficiently noisy that the graph is the only currently good way of detecting max-rss changes, IMO. |
|
@Mark-Simulacrum one good thing we could do is have a checklist that all those who do triage should check. I'd be nice to know that we're always checking the same things. |
|
https://github.com/rust-lang/rustc-perf/blob/master/triage/README.md is the place to update, I agree it'd be good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.