Skip to content

More clearly indicate procedure after perf run completes #890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rylev
Copy link
Member

@rylev rylev commented Jul 1, 2021

Attempts to address #887

@rylev rylev requested a review from Mark-Simulacrum July 1, 2021 17:15
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall, left a few minor comments. Also filed #891 for the future.

@Mark-Simulacrum Mark-Simulacrum merged commit b3bcf98 into rust-lang:master Jul 4, 2021
@rylev rylev deleted the better-perf-finished-messaging branch July 28, 2021 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants