Skip to content

Add summary #927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2021
Merged

Add summary #927

merged 2 commits into from
Jul 21, 2021

Conversation

rylev
Copy link
Member

@rylev rylev commented Jul 20, 2021

Adds summary above benchmark tables

image

@lqd
Copy link
Member

lqd commented Jul 20, 2021

it would be good to vertically align these icons

@rylev
Copy link
Member Author

rylev commented Jul 21, 2021

@lqd thoughts?
image

@lqd
Copy link
Member

lqd commented Jul 21, 2021

I would personally increase the right spacing between the value and the icons, and try to horizontally center the value + icon container to the columns below. But there's no need to spend time on this specifically, it looks fine as-is and already provides value to users.

@rylev
Copy link
Member Author

rylev commented Jul 21, 2021

I agree regarding the spacing between the value and icons. As for aligning with the columns below, I'd like to avoid that since it visually implies that the values are related (which they're not). Perhaps having more a visual separator between the table and the summary could make this look cleaner.

Going to merge any way. At some point, we can do another visual cleanup.

@rylev rylev merged commit fdc50f5 into rust-lang:master Jul 21, 2021
@rylev rylev deleted the summary branch July 21, 2021 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants