Skip to content

Post merge improvements #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 6, 2021
Merged

Post merge improvements #993

merged 3 commits into from
Sep 6, 2021

Conversation

rylev
Copy link
Member

@rylev rylev commented Sep 6, 2021

This PR makes two improvements:

  • It separates formatting of master and try perf run summary messages so that they show the appropriate text in the appropriate scenario. (e.g., it fixes an issue where we were labeling merged PRs with labels that are only relevant after try runs)
  • It only shows a perf change as a regression, mixed, or an improvement in the after merge run if we are "definitely" sure that is relevant. This mirrors how triage works.

@rylev rylev merged commit d7f85aa into rust-lang:master Sep 6, 2021
@rylev rylev deleted the post-merge-improvements branch September 6, 2021 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rylev