Don't panic about debug info for Arm64 Windows unwind info #1537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Switching back to draft: this needs the version of cranelift bumped. |
|
This will need to wait for Cranelift 0.113, right? |
Correct. |
|
Updated to Cranelift 0.113 just now. Please rebase and this can be merged. |
dpaoliello
force-pushed
the
debugunwind
branch
from
2a1b815 to
bcb7de3
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CodeView debug info doesn't contain any information about unwind tables (
.xdataor.pdata), so ignore both Arm64 and x64 unwind info when emitting debug info.