Skip to content

Sync from rust 028c6f1454787c068ff5117e9000a1de4fd98374 #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 1, 2022

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Jan 1, 2022

This pulls in the merge commit from syncing to the rust repo. This ensures that git subtree doesn't report a conflict next sync.

(gentle reminder: make sure to not squash merge it this time)

@antoyo
Copy link
Contributor

antoyo commented Jan 1, 2022

Thanks!

Which option should I use?
"Create a merge commit" or "Rebase and merge"?

@bjorn3
Copy link
Member Author

bjorn3 commented Jan 1, 2022

The "create a merge commit" option.

@antoyo antoyo merged commit 0be9d1e into rust-lang:master Jan 1, 2022
@bjorn3 bjorn3 deleted the sync_from_rust branch January 1, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants