Rustup to rustc 1.60.0-nightly (a00e130da 2022-01-29) #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that deferred inlining has been disabled in LLVM, this shouldn't cause catastrophic size blowup.
Mark drop calls in landing pads `cold` instead of `noinline` Now that deferred inlining has been disabled in LLVM (#92110), this shouldn't cause catastrophic size blowup. I confirmed that the test cases from rust-lang/rust#41696 (comment) still compile quickly (<1s) after this change. ~Although note that I wasn't able to reproduce the original issue using a recent rustc/llvm with deferred inlining enabled, so those tests may no longer be representative. I was also unable to create a modified test case that reproduced the original issue.~ (edit: I reproduced it on CI by accident--the first commit timed out on the LLVM 12 builder, because I forgot to make it conditional on LLVM version) r? `@nagisa` cc `@arielb1` (this effectively reverts #42771 "mark calls in the unwind path as !noinline") cc `@RalfJung` (fixes #46515) edit: also fixes #87055
Replace `-Z symbol-mangling-version=v0` with `-C symbol-mangling-version=v0`. Replace `-Z symbol-mangling-version=legacy` with `-Z unstable-options -C symbol-mangling-version=legacy`.
The field is also renamed from `ident` to `name. In most cases, we don't actually need the `Span`. A new `ident` method is added to `VariantDef` and `FieldDef`, which constructs the full `Ident` using `tcx.def_ident_span()`. This method is used in the cases where we actually need an `Ident`. This makes incremental compilation properly track changes to the `Span`, without all of the invalidations caused by storing a `Span` directly via an `Ident`.
This saves a couple of Symbol::intern calls
…arf and msvc instructions
Given that these instructions are diverging, not every codegen backend may be able to produce a return value for them.
Some codegen backends may require all handlers to be immediately known
|
I'm locally getting several errors about traits not being implemented despite there clearly being a derive for them. For example error[E0308]: mismatched types
--> iter/adapters/intersperse.rs:79:30
|
79 | .intersperse_with(|| NotClone { u: 2 })
| ^^^^^^^^^^^^^^^^^
| |
| expected `&intersperse::test_intersperse_with::NotClone`, found struct `intersperse::test_intersperse_with::NotClone`
| help: consider borrowing here: `&NotClone { u: 2 }` |
|
Strange. |
|
Fixed it. Had to switch coretests to the 2021 edition. |
antoyo
approved these changes
Feb 1, 2022
bjorn3
force-pushed
the
rustup
branch
2 times, most recently
from
bdbb749 to
abee9ce
Compare
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR must not be squashed when merging.