Skip to content

Add doc for sending patches to GCC #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

GuillaumeGomez
Copy link
Member

No description provided.

All the commands are supposed to be run in the folder where you cloned GCC.

```bash
./contrib/gcc-changelog/git_check_commit.py

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have multiple commits, this script can also take a rev-list as argument. I often use it like this:
contrib/gcc-changelog/git_check_commit.py upstream/master..HEAD

(assuming you have an upstream origin with a master branch that you branched from).

For a specific commit you can also use the commit's hash as argument:

contrib/gcc-changelog/git_check_commit.py abdef78989

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Updating the PR then.

@GuillaumeGomez
Copy link
Member Author

Including suggestion from @CohenArthur

@davidmalcolm
Copy link

For patches that touch libgccjit, I wrote some notes here:
https://gcc.gnu.org/onlinedocs/jit/internals/index.html#submitting-patches

@GuillaumeGomez
Copy link
Member Author

I'm ashamed to say that I completely missed this part. ^^'

@antoyo antoyo merged commit 4ad266a into rust-lang:master Aug 17, 2023
@GuillaumeGomez GuillaumeGomez deleted the gcc-contribution branch August 17, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants