Implement checks for unnumbered TODOs and FIXMEs #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we want to match |
| // need. Round to the next power of two. | ||
| let file_size = f.src.as_ref().unwrap().len(); | ||
| let power = (file_size as f64).log2().ceil() as u32; | ||
| let buffer_cap = 2usize.pow(power); |
There was a problem hiding this comment.
You can do this far more efficiently with some bit twiddling: http://graphics.stanford.edu/~seander/bithacks.html#RoundUpPowerOf2
There was a problem hiding this comment.
Nice! What a great collection of hacks.
|
This is a really great PR, thanks! |
nrc
added a commit
that referenced
this pull request
Jun 15, 2015
Implement checks for unnumbered TODOs and FIXMEs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things: it saves the errors rustfmt finds in a report instead of immediately printing them, making some progress on https://github.com/nrc/rustfmt/issues/9.
It also adds checks for unnumbered TODOs and FIXMEs in the code. Basically we just check that any line containing a TODO matches the following regex:
But since we go through the results character by character, I implemented a state machine myself.
The output can get quite noisy --especially for rustfmt's own code--, so I added an option to forgo the check.
Note: the check treats all text equally. We're not making sure that we're in a comment. It may happen that we get false positives when there's a FIXME or TODO in a string literal, for example.