Remove global mutable config to allow for concurrency #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -14,7 +14,7 @@ use {NewlineStyle, BraceStyle, ReturnIndent}; | |||
| use lists::SeparatorTactic; | |||
| use issues::ReportTactic; | |||
|
|
|||
| #[derive(RustcDecodable)] | |||
| #[derive(RustcDecodable, Clone, Copy)] | |||
There was a problem hiding this comment.
This shouldn't be Copy - it might get more complex in the future and is already too big to morally be copy-able
|
This is a good idea, the only change I would make is to not copy the config around (see the comment on deriving copy). That is going to require changing a few of the uses to references and will need a few lifetime params scattered around, but should work. |
|
It luckily was very little work! |
|
Needs a rebase now |
|
@nrc Rebasified! |
nrc
added a commit
that referenced
this pull request
Jun 23, 2015
Remove global mutable config to allow for concurrency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make it possible to run idempotence/ system tests concurrently.