Fix bugs in width computation for bin op #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -302,7 +303,9 @@ fn rewrite_binary_op(context: &RewriteContext, | |||
| // operations with high precendence close together. | |||
| let rhs_result = try_opt!(rhs.rewrite(context, width, offset)); | |||
|
|
|||
| if rhs_result.len() > remaining_width { | |||
| // Secode condition is needed in case of line break not caused by a | |||
|
Thanks! |
nrc
added a commit
that referenced
this pull request
Jul 3, 2015
Fix bugs in width computation for bin op
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't had enough time to review and test @nrc merged, so I correct here a bug in #99 :
lhswas formatted intowidth, andrhsintomax_width, while the inverse should be done.