Skip to content

Don't apologise if its not our fault in warnings #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 16, 2015
Merged

Don't apologise if its not our fault in warnings #139

merged 2 commits into from
Jul 16, 2015

Conversation

nrc
Copy link
Member

@nrc nrc commented Jul 16, 2015

@marcusklaas
Copy link
Contributor

Looks good to me. I think one could argue that the message {pre, suf}fix isn't really a property of a FormattingError, but that's splitting hairs of course.

Is @bors watching this?

@bors r+

nrc added a commit that referenced this pull request Jul 16, 2015
@nrc
Merge pull request #139 from nrc/todo-sorry
fa4ef4d 
Don't apologise if its not our fault in warnings
@nrc nrc merged commit fa4ef4d into master Jul 16, 2015
@nrc
Copy link
Member Author

nrc commented Jul 16, 2015

Heh, no bors here

@marcusklaas marcusklaas deleted the todo-sorry branch September 27, 2015 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nrc @marcusklaas