Skip to content

RFC: Use block indent style for struct tuple #1746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 5, 2017

Conversation

topecongiro
Copy link
Contributor

Closes #1367.

@topecongiro topecongiro changed the title Use block indent style for struct tuple RFC: Use block indent style for struct tuple Jun 29, 2017
Copy link
Member

@nrc nrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thank you! r=me with the nit addressed.

src/expr.rs Outdated
}

#[allow(unused_variables)]
fn can_be_overflowed(&self, context: &RewriteContext, len: usize) -> bool {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer just use _ for the variables, rather than use the attribute here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I totally agree. Thanks!

@nrc
Copy link
Member

nrc commented Jul 5, 2017

Sorry, needs a rebase

@topecongiro
Copy link
Contributor Author

Rebased.

@nrc nrc merged commit 6b00353 into rust-lang:master Jul 5, 2017
@topecongiro topecongiro deleted the struct-tuple branch July 6, 2017 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants