Skip to content

Exclude prefix colon from span when rewriting comment #1945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 4, 2017
Merged

Exclude prefix colon from span when rewriting comment #1945

merged 2 commits into from
Sep 4, 2017

Conversation

topecongiro
Copy link
Contributor

@topecongiro topecongiro commented Sep 4, 2017 •
edited
Loading

This PR

  1. closes Unclosed comment after empty type parameter bound #1095.
  2. avoids cloning string by creating a wrapper type in rewrite_generics_inner().

@nrc nrc merged commit 435ab86 into rust-lang:master Sep 4, 2017
@nrc
Copy link
Member

nrc commented Sep 4, 2017

Thanks!

@topecongiro topecongiro deleted the issue-1095 branch September 8, 2017 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unclosed comment after empty type parameter bound
2 participants
@topecongiro @nrc