Fix broken tests under CRLF environment. #2029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #617 ... for now.
The problem was that some codes are assuming the newline in the input code is always '\n'. Especially, str.starts_with('\n') was breaking danger because it always fail in CRLF environment.
I'm still feeling uncomfortable that so many codes seems to not consider CRLF env, but fortunately str.ends_with('\n') and str.contains('\n') both work properly under CRLF env. At least, no tests are broken in Windows anymore.
Need to push #2028 beforehand to check if the tests are really fixed under Windows.