-
Notifications
You must be signed in to change notification settings - Fork 933
Adding where_single_line option #2030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
2ad8951
feat(where): adding where_single_line option and tests
afshinm 25b6a6b
fix(where): adding more tests
afshinm ec6738a
feat(where): changing the shape of where clause when where_single_lin…
afshinm e990a98
feat: newline_for_brace should avoid adding a new line where where_si…
afshinm 0e9f70e
fix(items): where_single_line should bypass the multi-item where clauses
afshinm c46e38b
fix(items): refactoring and removing redundant variables
afshinm f26070a
fix(items): where_single_line should not be functional when args are …
afshinm 608fc59
merge with upstream
afshinm c663833
fix(config): fixing conflict with upstream
afshinm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
// rustfmt-where_single_line: true | ||
// Where style | ||
|
||
|
||
fn lorem_two_items<Ipsum, Dolor, Sit, Amet>() -> T where Ipsum: Eq, Lorem: Eq { | ||
// body | ||
} | ||
|
||
fn lorem_multi_line<Ipsum, Dolor, Sit, Amet>( | ||
a: Aaaaaaaaaaaaaaa, | ||
b: Bbbbbbbbbbbbbbbb, | ||
c: Ccccccccccccccccc, | ||
d: Ddddddddddddddddddddddddd, | ||
e: Eeeeeeeeeeeeeeeeeee, | ||
) -> T | ||
where | ||
Ipsum: Eq, | ||
{ | ||
// body | ||
} | ||
|
||
fn lorem<Ipsum, Dolor, Sit, Amet>() -> T where Ipsum: Eq { | ||
// body | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
// rustfmt-where_single_line: true | ||
// Where style | ||
|
||
|
||
fn lorem_two_items<Ipsum, Dolor, Sit, Amet>() -> T | ||
where | ||
Ipsum: Eq, | ||
Lorem: Eq, | ||
{ | ||
// body | ||
} | ||
|
||
fn lorem_multi_line<Ipsum, Dolor, Sit, Amet>( | ||
a: Aaaaaaaaaaaaaaa, | ||
b: Bbbbbbbbbbbbbbbb, | ||
c: Ccccccccccccccccc, | ||
d: Ddddddddddddddddddddddddd, | ||
e: Eeeeeeeeeeeeeeeeeee, | ||
) -> T | ||
where | ||
Ipsum: Eq, | ||
{ | ||
// body | ||
} | ||
|
||
fn lorem<Ipsum, Dolor, Sit, Amet>() -> T | ||
where Ipsum: Eq { | ||
// body | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both the name of the option (where single line do what?) and the "documentation" (where what is layout?) are extremely confusing.
Configurations.md
does not help; as a user I have no idea what this does.[edit: filed #2580]