Refactorings #2042
Merged
Refactorings #2042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustfmt removes trailing comma from a function call. This could be a bug.
nrc
reviewed
Oct 9, 2017
src/chains.rs
Outdated
| @@ -198,7 +198,7 @@ pub fn rewrite_chain(expr: &ast::Expr, context: &RewriteContext, shape: Shape) - | |||
| if let Some(rw) = rewrite_chain_subexpr(last_subexpr, total_span, context, shape) { | |||
| let line_count = rw.lines().count(); | |||
| let fits_single_line = almost_total + first_line_width(&rw) <= one_line_budget; | |||
| if (line_count >= 5 && fits_single_line) || extend_last_subexr { | |||
| if fits_single_line && (line_count >= 5 && fits_single_line || extend_last_subexr) { | |||
There was a problem hiding this comment.
Should this be fits_single_line && (line_count >= 5 || extend_last_subexr) (I think they are equivalent)
There was a problem hiding this comment.
Yes, just a classic "Fix a typo" commit introducing another typo...
|
Thank you for the review! Fixed a typo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of small refactorings.
The last commit is suspicious, rustfmt removes trailing comma from function call.