Soft wrapping for comments #2102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also this PR prevents URLs from being split, in a heuristic way. |
nrc
reviewed
Oct 31, 2017
src/comment.rs
Outdated
| /// Returns true if the given string MAY include URLs or alike. | ||
| fn has_url(s: &str) -> bool { | ||
| // This function may return false positive, but should get its job done in most cases. | ||
| s.contains("https://") || s.contains("http://") |
There was a problem hiding this comment.
Could you add "file" and "ftp" schemes too please?
|
Thank you for the review! Updated. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a first step to implementing soft wrapping for comments (cc #535).
Note that this PR does NOT implement soft wrapping for doc comments (
///or//!). Currently each line of doc comments are rewritten on its own due to how it's implemented in AST (a vector ofast::Attribute). Fixing this will be in a different PR, hopefully.