fix some typos #2104
Merged
fix some typos #2104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrc
reviewed
Oct 31, 2017
src/patterns.rs
Outdated
| PatKind::Struct(ref path, ref fields, elipses) => { | ||
| rewrite_struct_pat(path, fields, elipses, self.span, context, shape) | ||
| PatKind::Struct(ref path, ref fields, ellipses) => { | ||
| rewrite_struct_pat(path, fields, ellipses, self.span, context, shape) |
src/patterns.rs
Outdated
| @@ -130,7 +130,7 @@ impl Rewrite for Pat { | |||
| fn rewrite_struct_pat( | |||
| path: &ast::Path, | |||
| fields: &[codemap::Spanned<ast::FieldPat>], | |||
| elipses: bool, | |||
| ellipses: bool, | |||
tests/source/expr.rs
Outdated
| @@ -233,7 +233,7 @@ fn repeats() { | |||
|
|
|||
| fn blocks() { | |||
| if 1 + 1 == 2 { | |||
| println!("yay arithmetix!"); | |||
| println!("yay arithmetics!"); | |||
There was a problem hiding this comment.
I removed this change from the PR
|
i updated the pr and squashed the commits with feedback addressed |
nrc
reviewed
Nov 1, 2017
tests/target/expr.rs
Outdated
| @@ -298,7 +298,7 @@ fn repeats() { | |||
|
|
|||
| fn blocks() { | |||
| if 1 + 1 == 2 { | |||
| println!("yay arithmetix!"); | |||
| println!("yay arithmetics!"); | |||
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the result of me testing out a WIP source code spell-checker
and your project was the random target this time.