Use an explicit flag to decide on whether to add brace compensation for block expression #2209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrc
reviewed
Nov 29, 2017
src/visitor.rs
Outdated
| &mut self, | ||
| b: &ast::Block, | ||
| inner_attrs: Option<&[ast::Attribute]>, | ||
| is_dummy: bool, |
There was a problem hiding this comment.
COuld we call is_dummy has_braces or something similar? It's not obvious to me what is_dummy means.
There was a problem hiding this comment.
Thanks for the review!
is_dummy is true when we manually construct a block for the body of closure. Since the block is not present in the original code I called it dummy.
I agree that using has_braces is better, it is more natural to use a flag that is true most of the time and false in a narrow case. And the name is clearer.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2207.