Keep vertical spaces between items or statements within range #2221
Conversation
There was a problem hiding this comment.
Thanks for the PR! The code looks good, but I think the upper bound default should be 2 rather than 1. Could you also add a couple of tests checking some other configurations please? (In particular which require inserting newlines, with and without comments).
| @@ -651,6 +651,10 @@ create_config! { | |||
| "Add trailing semicolon after break, continue and return"; | |||
| match_block_trailing_comma: bool, false, false, | |||
| "Put a trailing comma after a block based match arm (non-block arms are not affected)"; | |||
| blank_lines_upper_bound: usize, 1, false, | |||
|
Thank you for taking time to review this! I read your comment and it states that we should have either 0 or 1 blank line between items. Do you mean that the config values should represent the exclusive bound? |
|
This PR does not handle blank lines around comments. The blank lines in the example below will be kept untouched: fn foo()
// comment
fn bar() {}I am going to update this PR, add more tests. |
You are correct, sorry - my memory was not as good as I thought :-) |
|
Updated with handling of comments and tests. My apologies for messy commit history. |
|
Thank you! |
cc rust-lang/style-team#57.