-
Notifications
You must be signed in to change notification settings - Fork 933
Adding print!
to the list of specially-formatted format!
-like macros
#2240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -1818,7 +1818,7 @@ const FORMAT_LIKE_WHITELIST: &[&str] = &[ | |||
"eprintln!", | |||
"format!", | |||
"format_args!", | |||
"panic!", | |||
"print!", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expand this snippet below to see that panic!
appears in the list further below. Looking deeper now, though, panic!
belongs in the part of the list since it is part of the Standard Library. Shall I add it back and keep print!
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes please! And thank you very much for adding tests!
I realized that I didn't add similar tests for each of @topecongiro: |
@davidalber Adding more tests is awesome, thank you! The link is to the old version of |
|
||
// assert! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dropped the comments that indicate which macro is being tested because after adding so much duplication I feel the macro names jump out really clearly. I can add comments back if anyone feels strongly about it.
Thank you! |
This PR adds new tests for #549 and corrects a typo from #2219.
print!
to the list of specially-formatted macros.