unstable_features without CFG_RELEASE_CHANNEL #2249
Conversation
src/config.rs
Outdated
| () => { | ||
| option_env!("CFG_RELEASE_CHANNEL") | ||
| .map(|c| c == "nightly") | ||
| .map(|c| c != "nightly") | ||
| .unwrap_or(false) |
There was a problem hiding this comment.
It would be clearer, I think, to change this to unwrap_or(false) and leave the macro name and usage the same - we are still checking for nightly afterall.
There was a problem hiding this comment.
I assume you meant unwrap_or(true). Swapped back to this bool direction and tweaked the comment to still apply.
|
I going to toss my 2 cents in here and recommend that unstable features be hidden behind a cargo feature flag, rather than a compile time/runtime check for an environment variable. If this is something we can get a consensus on, I can work on getting that done. I just submitted a PR changing the behavior to a runtime check, without knowing this PR was open. If this PR gets merged, you can close #2259. |
Per discussion in #2228 #2228 (comment) #2228 (comment) Inline comment should explain the reasoning.
|
Thanks @CAD97 ! |
Per discussion in #2228
#2228 (comment)
#2228 (comment)
Inline comment should explain the reasoning.
Open to bikeshed.